Skip to content

fix(bench): replace frame() calls with read_frame(0) after API change#12

Merged
mvoof merged 2 commits into
mainfrom
fix/bench-read-frame
Jun 15, 2026
Merged

fix(bench): replace frame() calls with read_frame(0) after API change#12
mvoof merged 2 commits into
mainfrom
fix/bench-read-frame

Conversation

@mvoof

@mvoof mvoof commented Jun 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the telemetry benchmarks to use read_frame(0) instead of frame(). However, because the benchmarks use mock connections with null event handles, calling read_frame(0) triggers a 16ms sleep on every iteration. This causes the benchmarks to measure sleep overhead rather than actual frame parsing performance. It is recommended to revert these changes and keep using the frame() method.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread benches/telemetry_benches.rs
Comment thread benches/telemetry_benches.rs
@mvoof mvoof merged commit 9ff3aa4 into main Jun 15, 2026
1 check passed
@mvoof mvoof deleted the fix/bench-read-frame branch June 15, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant