tumblr: fix post URL#963
Open
mistydemeo wants to merge 1 commit into
Open
Conversation
The URL I was seeing in the notifications after posting was missing a trailing slash between the blog name and the post ID; it appears the URL that's coming in from the data doesn't contain one. The incorrect URL was in the format: https://www.tumblr.com/blogname00000000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL I was seeing in the notifications after posting was missing a trailing slash between the blog name and the post ID; it appears the URL that's coming in from the data doesn't contain one. The incorrect URL was in the format:
https://www.tumblr.com/blogname00000000I haven't had a chance to actually check the value being returned here (not sure the right way to debug this from within postybirb, sorry!), but I think this should fix it. The specific place I was seeing it was the "view" link im the "source URL" column of the notifications: