refactor: replace SubscriberBus usage in favor of event driven websocket emits#962
Open
mvdicarlo wants to merge 14 commits into
Open
refactor: replace SubscriberBus usage in favor of event driven websocket emits#962mvdicarlo wants to merge 14 commits into
mvdicarlo wants to merge 14 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A massive refactor that overhauls how we internally calculate websocket emits to make
emissions more granular and not require emitting every single record over the wire
whenever a single change is made.
To support this, lot of changes were required to be made around submission emissions
and a relatively large restructuring of login lifecycle ownership for accounts. Ownership
of login state is largely now managed by website instances themselves.
This is likely to have buried bugs and needs some general refinements but is overall
stable from initial testing.