Skip to content

feat: allow passing full asset to bypass looking up asset in mux#190

Open
jsanford8 wants to merge 1 commit into
mainfrom
js/allow-providing-asset
Open

feat: allow passing full asset to bypass looking up asset in mux#190
jsanford8 wants to merge 1 commit into
mainfrom
js/allow-providing-asset

Conversation

@jsanford8

@jsanford8 jsanford8 commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Broadly changes public workflow function signatures to accept either an asset ID or a pre-fetched MuxAsset, which could break callers and alters how playback IDs/policies are resolved. Runtime risk is moderated by added unit tests covering the new branching logic.

Overview
Allows callers to pass a full MuxAsset into major workflows (e.g. getSummaryAndTags, generateChapters, askQuestions, moderation, translations, embeddings) to bypass the Mux Video API fetch when the asset is already available.

Adds toPlaybackAsset (now exported) to derive playbackId/policy directly from an asset object, updates workflows to branch on string vs MuxAsset, and introduces unit tests asserting the correct path is taken (Mux fetch vs local resolution), including extra moderation coverage.

Reviewed by Cursor Bugbot for commit cb77d0f. Bugbot is set up for automated code reviews on this repo. Configure here.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@snyk-io

snyk-io Bot commented Apr 27, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jsanford8 jsanford8 changed the title allow passing full asset to bypass looking up asset in mux feat: allow passing full asset to bypass looking up asset in mux Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant