feat: allow passing full asset to bypass looking up asset in mux#190
Open
jsanford8 wants to merge 1 commit into
Open
feat: allow passing full asset to bypass looking up asset in mux#190jsanford8 wants to merge 1 commit into
jsanford8 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Broadly changes public workflow function signatures to accept either an asset ID or a pre-fetched
MuxAsset, which could break callers and alters how playback IDs/policies are resolved. Runtime risk is moderated by added unit tests covering the new branching logic.Overview
Allows callers to pass a full
MuxAssetinto major workflows (e.g.getSummaryAndTags,generateChapters,askQuestions, moderation, translations, embeddings) to bypass the Mux Video API fetch when the asset is already available.Adds
toPlaybackAsset(now exported) to deriveplaybackId/policydirectly from an asset object, updates workflows to branch onstringvsMuxAsset, and introduces unit tests asserting the correct path is taken (Mux fetch vs local resolution), including extra moderation coverage.Reviewed by Cursor Bugbot for commit cb77d0f. Bugbot is set up for automated code reviews on this repo. Configure here.