Skip to content

fix(finance): sort cost breakdown groups by min display_order of members#60

Merged
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:fix/costing-product-calculation
Jun 30, 2026
Merged

fix(finance): sort cost breakdown groups by min display_order of members#60
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:fix/costing-product-calculation

Conversation

@ilramdhan

Copy link
Copy Markdown
Member

Previously groups were ordered by first-occurrence, causing Machine to appear before Raw Material. Now groups are sorted by the minimum display_order among their member parameters, matching the reference Excel group sequence.

Description

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🎨 UI/UX improvement
  • ♻️ Refactor
  • 📚 Documentation
  • 🔧 Chore (deps, config)

Module/Component Affected

  • Dashboard
  • Finance
  • HR / IT / CI / EXSIM
  • Components (common/)
  • Components (ui/)
  • Navigation
  • API Routes

Changes Made

Related Issues

Fixes #
Related to #

Screenshots

Before

After

Testing Performed

Manual Testing

  • Desktop (1440px+)
  • Tablet (768px)
  • Mobile (375px)
  • Light mode
  • Dark mode

Browser Testing

  • Chrome
  • Firefox
  • Safari
  • Edge

Build Verification

  • npm run lint passes
  • npx tsc --noEmit passes
  • npm run build succeeds

Accessibility

  • Keyboard navigation works
  • Screen reader compatible
  • Proper ARIA labels
  • Color contrast adequate

Performance

  • No unnecessary re-renders
  • Images optimized
  • Heavy components lazy loaded

Pre-merge Checklist

  • I have read and followed RULES.md
  • I have read and followed CONTRIBUTING.md
  • Loading states implemented (if data fetching)
  • Error handling present
  • Component props typed properly
  • Uses semantic color classes
  • Responsive design tested
  • Dark mode compatible
  • Screenshots included (for UI changes)

Reviewer Notes

Previously groups were ordered by first-occurrence, causing Machine to
appear before Raw Material. Now groups are sorted by the minimum
display_order among their member parameters, matching the reference
Excel group sequence.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ilramdhan ilramdhan merged commit b5d582f into mutugading:main Jun 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant