Fix/costing product calculation#59
Merged
ilramdhan merged 3 commits intoJun 29, 2026
Merged
Conversation
Both routing and params-only dialogs now automatically retry failed chunks until no more improvement is possible (max 5/3 passes). Each retry pass benefits from newly-imported products in DbProductSet: - Pass 1: ~50% chunks succeed (few products in DB) - Pass 2: ~80% succeed (dependency chain resolves) - Pass 3+: converges to ~100% or stops on no improvement User no longer needs to manually click Retry multiple times. UI shows 'Pass 2/5 — retrying N failed chunks...' during auto-retry. Chunks already succeeded are skipped on subsequent passes. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…deps Phase 1: import product_master + parameters (no cross-product refs) Phase 2: import routing AFTER all products are in DB (no deadlocks) Previously, chunk A could fail because it referenced products in chunk B, while chunk B failed because it referenced products in chunk A. Auto-retry could not resolve circular dependencies. The two-phase approach eliminates this entirely: - Phase 1 has no cross-product routing references → always converges - Phase 2 runs after Phase 1 completes → all products in DbProductSet Also adds BULK_PRODUCTS_ONLY_CONFIG and BULK_ROUTING_ONLY_CONFIG to chunked-importer.ts for use in the two-phase dialog. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Replace the browser-side chunked importer (SheetJS web worker + multi-pass auto-retry) with the v2 ETL flow: getImportUploadURL -> PUT the file directly to MinIO (with progress) -> startCostingImport -> poll the job to DONE/PARTIAL with an error-report link. A single unified bulk-import dialog drives both datasets via a `kind` prop (product_routing | params_only). Remove the chunked-importer + worker, the params-only dialog, and the old bytes/validate BFF routes; add the upload-url + start BFF routes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Frontend]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Module/Component Affected
Changes Made
Related Issues
Fixes #
Related to #
Screenshots
Before
After
Testing Performed
Manual Testing
Browser Testing
Build Verification
npm run lintpassesnpx tsc --noEmitpassesnpm run buildsucceedsAccessibility
Performance
Pre-merge Checklist
Reviewer Notes