Skip to content

fix(frontend): surface validate timeout error message instead of 503 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilramdhan merged 1 commit into from
Jun 28, 2026
Merged

fix(frontend): surface validate timeout error message instead of 503 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/app/api/v1/finance/costing/validate/bulk_product_routing/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ export async function POST(request: NextRequest) {
metadata,
)

// Surface backend errors (e.g. timeout on very large files) as a non-2xx response
// so the frontend can display the message rather than showing an empty result.
if (res.base && !res.base.isSuccess) {
return NextResponse.json({ base: res.base }, { status: 422 })
}

return NextResponse.json({
isValid: res.isValid,
sheets: res.sheets.map((sheet) => ({
Expand Down
5 changes: 4 additions & 1 deletion src/services/finance/cost-import-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,10 @@ export async function validateBulkProductRoutingFile(
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ fileContent, fileName: file.name }),
})
if (!res.ok) throw new Error(`Validation failed: ${res.status}`)
if (!res.ok) {
const errJson = await res.json().catch(() => null)
throw new Error(errJson?.base?.message || `Validation failed: ${res.status}`)
}
const json = await res.json()

if (!json.base?.isSuccess && json.base?.isSuccess !== undefined) {
Expand Down
Loading