Feat/rbac page scoped permissions

[ilramdhan]

Description

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 💥 Breaking change (fix or feature that changes existing API)
• ♻️ Refactor (code change without new feature or bug fix)
• 📚 Documentation update
• 🧪 Test update
• 🔧 Chore (dependencies, config, etc.)

Service(s) Affected

• Finance Service
• IAM Service
• Shared Proto (gen/)
• Root/Common

Changes Made

Related Issues

Fixes #
Related to #

API Changes (if applicable)

Proto Changes

+ // Added
- // Removed

Breaking Changes

Testing Performed

Unit Tests

• New unit tests added
• Existing unit tests pass
• Coverage maintained/improved

Integration Tests

• New integration tests added
• Existing integration tests pass

Manual Testing

# Commands used for testing
grpcurl -plaintext localhost:50051 ...
curl http://localhost:8080/...

Lint & Build

• golangci-lint run ./... passes
• go build ./... succeeds
• go test -race ./... passes

Database (if applicable)

• Migration added
• Migration tested (up and down)
• No breaking schema changes (or documented)

Documentation

• README.md updated (if needed)
• RULES.md updated (if needed)
• Proto comments updated
• OpenAPI regenerated

Rollback Plan

Screenshots/Logs (if applicable)

---

Pre-merge Checklist

• I have read and followed RULES.md
• I have read and followed CONTRIBUTING.md
• Clean Architecture principles followed
• All errors are properly handled
• Context is passed appropriately
• Structured logging is used
• No hardcoded secrets
• PR description is complete and clear
• CI checks are passing

Reviewer Notes

[Copilot]

Pull request overview

This PR introduces page-scoped (menu-scoped) RBAC permissions in the IAM service by adding menu_id to permissions, backfilling existing permissions to menus, and exposing/filtering this information through repositories and gRPC/OpenAPI/proto models.

Changes:

• Add mst_permission.menu_id (FK to mst_menu) plus an index, and backfill existing permission rows to menu pages via a migration.
• Extend permission persistence/query paths to LEFT JOIN mst_menu for menu_title, add menu-based filtering and a ListByMenu repository method.
• Propagate menuId/menuTitle through domain, gRPC handlers, and generated OpenAPI/proto artifacts; add/extend tests.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
services/iam/migrations/postgres/000065_add_menu_id_to_permission.up.sql	Adds nullable menu_id FK column to mst_permission and an index for active rows.
services/iam/migrations/postgres/000065_add_menu_id_to_permission.down.sql	Drops the new index and column on rollback.
services/iam/migrations/postgres/000066_backfill_permission_menu_id.up.sql	Backfills mst_permission.menu_id using permission_code → menu_code mapping.
services/iam/migrations/postgres/000066_backfill_permission_menu_id.down.sql	Clears menu_id for the mapped permission codes on rollback.
services/iam/internal/infrastructure/postgres/role_repository.go	Extends scanned permission rows to include menu_id and menu_title when reconstructing domain permissions.
services/iam/internal/infrastructure/postgres/permission_repository.go	Centralizes permission SELECT columns + menu join, adds menu filter/order, and introduces ListByMenu.
services/iam/internal/infrastructure/postgres/permission_repository_test.go	Adds integration tests covering menu_id round-trip and menu-scoped listing.
services/iam/internal/infrastructure/postgres/menu_repository.go	Updates permission reconstruction signature usage after adding menu fields.
services/iam/internal/domain/role/repository.go	Extends repository interface with ListByMenu and adds MenuID filter param.
services/iam/internal/domain/role/entity.go	Adds menuID/menuTitle to Permission entity, validates non-empty descriptions, and extends update semantics.
services/iam/internal/domain/role/entity_test.go	Updates tests for new Permission constructors and adds empty-description cases.
services/iam/internal/delivery/grpc/user_handler.go	Adjusts direct permissions vs effective permissions in GetUserRolesAndPermissions.
services/iam/internal/delivery/grpc/role_handler.go	Adds menuId/menuTitle fields to PermissionDetail proto mapping.
services/iam/internal/delivery/grpc/permission_handler.go	Parses menuId for create/update and threads menuId through list requests.
services/iam/internal/application/permission/update_handler.go	Passes MenuID through domain update call.
services/iam/internal/application/permission/list_handler.go	Threads MenuID through to repository list params.
services/iam/internal/application/permission/handlers_test.go	Updates mocks/tests for new permission reconstruction signature and repository interface method.
services/iam/internal/application/permission/create_handler.go	Passes optional MenuID into the domain permission constructor.
gen/openapi/iam/v1/role.swagger.json	Regenerates OpenAPI with menuId filtering and permission menu fields.
gen/iam/v1/role.pb.go	Regenerates protobuf Go output with menu_id/menu_title fields and request filtering.

Files not reviewed (1)

• gen/iam/v1/role.pb.go: Generated file

Comments suppressed due to low confidence (2)

services/iam/internal/application/permission/update_handler.go:52

• This handler now supports updating MenuID, but the postgres PermissionRepository.Update SQL does not update mst_permission.menu_id. Menu scoping changes will be applied in-memory and then silently lost when persisted.

	if err := entity.Update(cmd.Name, cmd.Description, cmd.IsActive, cmd.MenuID, cmd.UpdatedBy); err != nil {
		return nil, err
	}

	// 4. Persist

services/iam/internal/infrastructure/postgres/permission_repository.go:236

• ListPermissions uses a user-provided SortBy in ORDER BY; the fallback sortBy = params.SortBy allows arbitrary SQL fragments and can lead to ORDER BY injection or runtime SQL errors. SortBy should be restricted to an explicit allowlist of supported fields (including any API synonyms).

	if params.SortBy != "" {
		if mapped, ok := sortColumnMap[params.SortBy]; ok {
			sortBy = mapped
		} else {
			sortBy = params.SortBy

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.