Add Ignition 8.3 container support#83
Closed
kevinherron wants to merge 1 commit into
Closed
Conversation
Update commissioning, readiness, and module selection for Ignition 8.3. Parse third-party module descriptors so unsigned modules and gateway dependencies can be enabled automatically, and use Testcontainers 2 for compatibility with current Docker engines.
Contributor
Author
|
This basically replaces support for 8.1 with 8.3 instead of trying to support both. I'm using it locally so I thought I'd throw it up here. No hurt feelings if you close it / don't want it. |
Contributor
|
Looks good, I especially like the improved health check. For my use case, I'd like for I'd like to combine the functional improvements made here (health-check, version updates, developer mode) with the versioned API from my local build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module.xmlRUNNINGstate0.5.0-SNAPSHOTDetails
withDeveloperMode()passes the required-Dignition.allowunsignedmodules=trueJVM argument after the entrypoint's--delimiter. Entrypoint arguments are composed once so developer mode, debug settings, gateway restoration, memory settings, and additional arguments can be used together.Third-party module archives are validated and securely parsed before startup. Their module IDs and gateway-scoped dependencies are added to
GATEWAY_MODULES_ENABLED, while their IDs are also added toACCEPT_MODULE_CERTS. This allows unsigned modules and their required gateway modules to participate in automated commissioning without callers duplicating the module dependency graph.Both singular and plural
PathandStringthird-party-module APIs are available. Existing 0.4.3 capabilities such as explicit license acceptance, opt-in credentials, gateway backups, additional arguments, and mapped-port and URL helpers remain available.The readiness strategy now polls
/StatusPinguntil the response is exactly{"state":"RUNNING"}. Docker can otherwise report the container as healthy while the gateway is still inCOMMISSIONING.Compatibility notes
GatewayModuleidentifiers now represent Ignition 8.3 module IDs.Verification
Ran the complete test suite with an actual unsigned Modbus Server Driver module:
Results:
testcontainers-ignition: 8 passed, 0 failed, 0 errors, 0 skippedinductiveautomation/ignition:8.3.80.5.0-SNAPSHOTpublished successfully to Maven LocalThe downstream
modbus-server-driverbuild was also verified against this snapshot: