Skip to content

[Tab Layout] Allow fingering string text to affect which tablature string is attempted to apply on a linked staff/tab staff#22254

Closed
Jojo-Schmitz wants to merge 3 commits into
musescore:masterfrom
Jojo-Schmitz:StringTextAffectsTablaturePosition
Closed

[Tab Layout] Allow fingering string text to affect which tablature string is attempted to apply on a linked staff/tab staff#22254
Jojo-Schmitz wants to merge 3 commits into
musescore:masterfrom
Jojo-Schmitz:StringTextAffectsTablaturePosition

Conversation

@Jojo-Schmitz

@Jojo-Schmitz Jojo-Schmitz commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

Port of Jojo-Schmitz#403

Resolves: #22228, the 1st part:

320237994-b362223a-c77d-4bc1-98b5-60b06607446b.mp4

And now 2nd part too.

320378156-3339da87-9239-4aeb-ae29-3a7f24093029.mp4

@Jojo-Schmitz

Copy link
Copy Markdown
Contributor Author

The question mark stuff doesn't work though

@worldwideweary

Copy link
Copy Markdown
Contributor

If it's of any value, the "?" in MS3 is got by way of:

static const QString unknownFret = QString("?");

QString StaffType::fretString(int fret, int string, bool ghost) const
      {
      if (fret == INVALID_FRET_INDEX)
            return unknownFret;

which is invoked during Note::layout() after the handling of String Number texts in my PR for "3.7"... here though in Mu4 the function called is setFretString() , but its invocation occurs beforehand in relation to this commit. Maybe a relocation of the code beforehand would fix the lack of "questionable results" ... "?" ... ?

@Jojo-Schmitz
Jojo-Schmitz force-pushed the StringTextAffectsTablaturePosition branch 4 times, most recently from 5d7ee95 to d366148 Compare April 8, 2024 10:35
@Jojo-Schmitz

Jojo-Schmitz commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

Changing the order does not help with the ?, but it does together with another small change/addition

@Jojo-Schmitz
Jojo-Schmitz force-pushed the StringTextAffectsTablaturePosition branch from d366148 to c873d6b Compare April 8, 2024 13:07
Jojo-Schmitz and others added 2 commits April 8, 2024 15:07
…ring is attempted to apply on a linked staff/tab staff

Port of [#403](#403), 1st commit
@Jojo-Schmitz
Jojo-Schmitz force-pushed the StringTextAffectsTablaturePosition branch from c873d6b to 7004821 Compare April 8, 2024 13:07
@Jojo-Schmitz
Jojo-Schmitz force-pushed the StringTextAffectsTablaturePosition branch from 7004821 to b01426b Compare April 8, 2024 13:15
@worldwideweary

worldwideweary commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

P.S. This stuff is mainly for now as a testing, so it's not necessarily 'worthy' of going into master branch. Like for instance, apparently capo texts "transpose" an instrument, and in that sense this PR wouldn't be too desirable. I was unaware that it functioned as a "movable transposition" in MS3 rather than like a physical capo where it disables frets below the capo. It does things like:"Fret 12 now sounds as if it were Fret 15" or something.

Scorster provided an mscz. image with "It's late, and I'll have to think this through. But I don't think a Staff Text Line with Capo properties needs to affect anything in the tablature staff":

image

The capo 5 and 8 still allow for below capo fret positions. Not sure how to continue with it. For me personally, it would've made sense to disable frets below the capo and then reform the automatic translation from treble to linked tab score if possible, but that's even more work than what has been done so far.... as it would require not just updating any one fret but the entire automatically formed chord shape....

So maybe should retract that second commit so that it continues as it was designed by whoever designed it.

@Jojo-Schmitz
Jojo-Schmitz marked this pull request as draft April 8, 2024 19:09
@Jojo-Schmitz

Copy link
Copy Markdown
Contributor Author

Even if it currently is just for testing and work in progress: testing and comments are welcome

@Jojo-Schmitz
Jojo-Schmitz deleted the StringTextAffectsTablaturePosition branch September 3, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set tablature string assignments via String Number objects and Capo/Barre lines

2 participants