[Tab Layout] Allow fingering string text to affect which tablature string is attempted to apply on a linked staff/tab staff#22254
Conversation
9f72671 to
b429014
Compare
|
The question mark stuff doesn't work though |
|
If it's of any value, the "?" in MS3 is got by way of: static const QString unknownFret = QString("?");
QString StaffType::fretString(int fret, int string, bool ghost) const
{
if (fret == INVALID_FRET_INDEX)
return unknownFret;which is invoked during Note::layout() after the handling of String Number texts in my PR for "3.7"... here though in Mu4 the function called is |
5d7ee95 to
d366148
Compare
|
Changing the order does not help with the ?, but it does together with another small change/addition |
d366148 to
c873d6b
Compare
c873d6b to
7004821
Compare
7004821 to
b01426b
Compare
|
P.S. This stuff is mainly for now as a testing, so it's not necessarily 'worthy' of going into master branch. Like for instance, apparently capo texts "transpose" an instrument, and in that sense this PR wouldn't be too desirable. I was unaware that it functioned as a "movable transposition" in MS3 rather than like a physical capo where it disables frets below the capo. It does things like:"Fret 12 now sounds as if it were Fret 15" or something. Scorster provided an mscz. image with "It's late, and I'll have to think this through. But I don't think a Staff Text Line with Capo properties needs to affect anything in the tablature staff": The capo 5 and 8 still allow for below capo fret positions. Not sure how to continue with it. For me personally, it would've made sense to disable frets below the capo and then reform the automatic translation from treble to linked tab score if possible, but that's even more work than what has been done so far.... as it would require not just updating any one fret but the entire automatically formed chord shape.... So maybe should retract that second commit so that it continues as it was designed by whoever designed it. |
|
Even if it currently is just for testing and work in progress: testing and comments are welcome |

Port of Jojo-Schmitz#403
Resolves: #22228, the 1st part:
320237994-b362223a-c77d-4bc1-98b5-60b06607446b.mp4
And now 2nd part too.
320378156-3339da87-9239-4aeb-ae29-3a7f24093029.mp4