fix: Implement IDisposable on ShortcutService and dispose on app exit

[Copilot]

ShortcutService held a Window reference and accumulated KeyBinding registrations with no cleanup path, leaking resources on app shutdown.

Changes

• ShortcutService: Added : IDisposable to the class declaration — the Dispose() method already existed (calls UnregisterAll() + nulls _window) but the interface was never declared.
• App.axaml.cs: Wired ShortcutService.Instance?.Dispose() into IClassicDesktopStyleApplicationLifetime.Exit to guarantee cleanup on shutdown.

desktop.Exit += (_, _) => ShortcutService.Instance?.Dispose();

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• av-build-tel-api-v1.avaloniaui.net
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.29/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.29/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll 20' --output-dircredential.username (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Adds a guaranteed cleanup path for ShortcutService on application shutdown by formally implementing IDisposable and invoking disposal from the Avalonia desktop lifetime exit hook.

Changes:

• Declared ShortcutService : IDisposable (the Dispose() method already existed).
• Hooked ShortcutService disposal into IClassicDesktopStyleApplicationLifetime.Exit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
Services/ShortcutService.cs	Declares IDisposable on ShortcutService to match its existing Dispose() implementation.
App.axaml.cs	Disposes ShortcutService on desktop app exit to ensure keybindings/window references are cleared during shutdown.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

ShortcutService.Instance is non-nullable and lazily creates the singleton (_instance ??= new ShortcutService()). Using ShortcutService.Instance?.Dispose() will still instantiate the service during shutdown even if it was never used, and the null-conditional is redundant. If the intent is to dispose only when already created, consider adding a static DisposeInstance()/TryGetInstance() (or exposing a Current/MaybeInstance that returns _instance) and call that from desktop.Exit.