Migrate to PHPUnit 12 attributes and add new helper tests - #177
Merged
Conversation
Comment on lines
+148
to
+150
| // Trigger autoloader to load src/Libilsws.php where APIException is defined | ||
| $ilsws = new Libilsws($this->dummyYamlPath); | ||
| $exception = new \Libilsws\APIException(); |
Comment on lines
+161
to
+165
| // 2. Test plain text fallback when JSON is invalid | ||
| $plainError = 'Raw database connection timeout'; | ||
| $result2 = $exception->errorMessage($plainError, 500); | ||
| $this->assertEquals('HTTP 500: SirsiDynix Web Services unavailable - Raw database connection timeout', $result2); | ||
|
|
Comment on lines
13
to
23
| "php": ">=8.1", | ||
| "ext-curl": "*", | ||
| "ext-json": "*", | ||
| "phpmailer/phpmailer": "^6.8", | ||
| "phpmailer/phpmailer": ">=7.0", | ||
| "symfony/yaml": "^6.0|^7.0", | ||
| "twig/twig": "^3.0" | ||
| "twig/twig": ">=3.0" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^10.5", | ||
| "symfony/var-dumper": "^6.0" | ||
| "phpunit/phpunit": ">=10.5", | ||
| "symfony/var-dumper": ">=6.0" | ||
| }, |
…ghten composer version constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.