Skip to content

replace Codec::from(u64) with TryFrom impl#44

Merged
vmx merged 1 commit into
multiformats:masterfrom
datalove-app:misc
Mar 9, 2020
Merged

replace Codec::from(u64) with TryFrom impl#44
vmx merged 1 commit into
multiformats:masterfrom
datalove-app:misc

Conversation

@sunny-g

@sunny-g sunny-g commented Mar 8, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rklaehn rklaehn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@vmx vmx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sunny-g.

We are currently in the transition to a license change. Could you please leave a comment that you agree on that change at #25?

@vmx

vmx commented Mar 9, 2020

Copy link
Copy Markdown
Member

The code coverage failure wasn't introduced by this change, hence merging it.

@vmx vmx merged commit ef94e40 into multiformats:master Mar 9, 2020
@sunny-g

sunny-g commented Mar 9, 2020

Copy link
Copy Markdown
Contributor Author

I explicitly and publicly agree to the license/contributor changes detailed in #25 :)

rklaehn pushed a commit to Actyx/rust-cid that referenced this pull request May 9, 2020
Adds support for blake2b256 and blake2s128.

@Guardian88 Guardian88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello-wolrd# @all-countributors

@Guardian88

Copy link
Copy Markdown

Hello-Wolrd# @open-source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants