Skip to content

fix(#757): six C4456 shadowed locals block the Windows test compile #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
localai-bot merged 2 commits into from
Aug 14, 2026
Merged

fix(#757): six C4456 shadowed locals block the Windows test compile #779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b13228
fix(#757): six C4456 shadowed locals block the Windows test compile
mudler Aug 14, 2026
db976db
merge: main @ acc757409 into row/FIX-MSVC-C4456-SHADOW (#757)
mudler Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tests/vt/test_backend_cross_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,15 +511,15 @@ TEST_CASE("ReshapeAndCache scatters into the KV cache BIT-EXACTLY") {
}
std::vector<float> ref_comb = combined;
{
vt::Backend& cpu = vt::GetBackend(DeviceType::kCPU);
Queue cq = cpu.CreateQueue();
const Device cd{DeviceType::kCPU, 0};
std::vector<float> ck = knew, cv = vnew, cslots_f;
std::vector<int64_t> cslots = slots;
Tensor tk = Tensor::Contiguous(ck.data(), DType::kF32, cd, {kTokens, kHk, kD});
Tensor tv = Tensor::Contiguous(cv.data(), DType::kF32, cd, {kTokens, kHk, kD});
vt::Backend& fcpu = vt::GetBackend(DeviceType::kCPU);
Queue fq = fcpu.CreateQueue();
const Device fd{DeviceType::kCPU, 0};
std::vector<float> fk = knew, fv = vnew, fslots_f;
std::vector<int64_t> fslots = slots;
Tensor tk = Tensor::Contiguous(fk.data(), DType::kF32, fd, {kTokens, kHk, kD});
Tensor tv = Tensor::Contiguous(fv.data(), DType::kF32, fd, {kTokens, kHk, kD});
Tensor tcomb =
Tensor::Contiguous(ref_comb.data(), DType::kF32, cd, {kBlocks * 2 * within});
Tensor::Contiguous(ref_comb.data(), DType::kF32, fd, {kBlocks * 2 * within});
auto slice = [&](int which) {
Tensor t = tcomb;
t.data = static_cast<char*>(t.data) +
Expand All @@ -535,10 +535,10 @@ TEST_CASE("ReshapeAndCache scatters into the KV cache BIT-EXACTLY") {
t.stride[3] = 1;
return t;
};
Tensor tsm = Tensor::Contiguous(cslots.data(), DType::kI64, cd, {kTokens});
Tensor tsm = Tensor::Contiguous(fslots.data(), DType::kI64, fd, {kTokens});
Tensor tkc = slice(0), tvc = slice(1);
vt::ReshapeAndCache(cq, tk, tv, tkc, tvc, tsm);
cpu.DestroyQueue(cq);
vt::ReshapeAndCache(fq, tk, tv, tkc, tvc, tsm);
fcpu.DestroyQueue(fq);
}

for (DeviceType dt : RegisteredDevices()) {
Expand Down
Loading