Skip to content

fix(build): main is RED — hf_snapshot.h calls HfSnapshot before it is declared (#551, #546) #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
localai-bot wants to merge 1 commit into from
Closed

fix(build): main is RED — hf_snapshot.h calls HfSnapshot before it is declared (#551, #546) #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions tests/parity/hf_snapshot.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@ inline constexpr const char* kQwen27NvfP4Revision =
inline constexpr const char* kNemotron35LightningNvfP4Revision =
"29f2d1746d8f41e316523194b19018707749b1b1";

// The Nemotron-3.5-Lightning gate model (#517). Unlike the Qwen pins above,
// this one is NOT in the HF cache: it is staged on the NAS as a `local_dir`
// snapshot at `$CHECKPOINT_ROOT/nemotron-3.5-lightning-30b-nvfp4`, so there is
// no `models--org--name/snapshots/<rev>` layout to resolve. The env override is
// therefore the ONLY reachable path, and the cache spelling below exists so the
// revision still names what the golden belongs to. Absent env var => "" => the
// caller emits its loud SKIP, which is the intended behavior off the gate host.
inline std::string Nemotron35LightningSnapshot() {
return HfSnapshot("models--nvidia--NVIDIA-Nemotron-3.5-Lightning-30B-A3B-NVFP4",
kNemotron35LightningNvfP4Revision,
"VT_NEMOTRON35_SNAPSHOT");
}

// Snapshot directory for `<repo>` at `revision`, or "" when it is not cached
// (the caller then emits its loud SKIP). `env_override`, when set and non-empty,
// names an explicit snapshot directory for a deliberate different-checkpoint
Expand Down Expand Up @@ -178,6 +165,19 @@ inline std::string Qwen27DFlashDraftSnapshot() {
return HfSnapshot("models--z-lab--Qwen3.6-27B-DFlash",
kQwen27DFlashDraftRevision, "VT_DFLASH_DRAFT_SNAPSHOT");}

// The Nemotron-3.5-Lightning gate model (#517). Unlike the Qwen pins above,
// this one is NOT in the HF cache: it is staged on the NAS as a `local_dir`
// snapshot at `$CHECKPOINT_ROOT/nemotron-3.5-lightning-30b-nvfp4`, so there is
// no `models--org--name/snapshots/<rev>` layout to resolve. The env override is
// therefore the ONLY reachable path, and the cache spelling below exists so the
// revision still names what the golden belongs to. Absent env var => "" => the
// caller emits its loud SKIP, which is the intended behavior off the gate host.
inline std::string Nemotron35LightningSnapshot() {
return HfSnapshot("models--nvidia--NVIDIA-Nemotron-3.5-Lightning-30B-A3B-NVFP4",
kNemotron35LightningNvfP4Revision,
"VT_NEMOTRON35_SNAPSHOT");
}

} // namespace parity

#endif // VLLM_TESTS_PARITY_HF_SNAPSHOT_H_
Loading