Skip to content

fix(golf): post-deploy UX bugfixes#196

Merged
aaylward merged 1 commit into
mainfrom
ux-fixes
Mar 9, 2026
Merged

fix(golf): post-deploy UX bugfixes#196
aaylward merged 1 commit into
mainfrom
ux-fixes

Conversation

@aaylward

@aaylward aaylward commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes 4 UX bugs found after deploying the golf UX overhaul (#192).

What Changed

  • Knock button during peek phase: Added allPlayersPeeked guard so the knock button only appears after all players have finished peeking at their initial cards
  • Held card layout shift: Moved the held card from a separate block element (which pushed the player's card grid down) to an inline third "pile" alongside Deck and Discard. Uses visibility: hidden when empty to reserve space and prevent any layout jump.
  • Mobile header too tall: Made the game header horizontal on mobile (was stacking vertically), reduced padding/font sizes, hid the Share Game button on screens ≤768px to keep the playing area above the fold
  • Join new game broken: When player B clicks "Join Game" from the game-end overlay, the old game state was still set, potentially blocking the join. Now clears game state before calling joinGame.
  • Rules modal typo: Fixed "6 cards in 2×3 grid" to "4 cards in 2×2 grid"

Testing Done

  • TypeScript typecheck — clean
  • Vitest — 214 tests passing
  • Verified knock button logic against allPlayersPeeked flag

🤖 Generated with Claude Code

- Hide knock button during peek phase (guard with allPlayersPeeked)
- Move held card inline with piles to prevent layout shift
- Compact mobile game header (inline layout, hide share button)
- Clear game state before joining new game to fix join link
- Fix rules modal: 4 cards in 2x2 grid, not 6 in 2x3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
muchq 96f772c Commit Preview URL

Branch Preview URL
Mar 09 2026, 10:13 PM

@aaylward aaylward enabled auto-merge (squash) March 9, 2026 22:14
@aaylward aaylward merged commit 14c7c47 into main Mar 9, 2026
2 checks passed
@aaylward aaylward deleted the ux-fixes branch March 9, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant