Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/apps/golf/components/PermalinkDisplay.module.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
.permalinkDisplay {
background: rgba(255, 255, 255, 0.1);
border: 1px solid rgba(255, 255, 255, 0.2);
border-radius: 8px;
padding: 12px;
margin: 8px 0;
}
Expand Down
30 changes: 9 additions & 21 deletions src/apps/golf/components/PermalinkDisplay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const PermalinkDisplay = ({ label, url, onCopy }: PermalinkDisplayProps) => {
case 'error':
return 'Failed'
default:
return 'Copy Link'
return label
}
}

Expand All @@ -81,26 +81,14 @@ const PermalinkDisplay = ({ label, url, onCopy }: PermalinkDisplayProps) => {

return (
<div className={styles.permalinkDisplay}>
<div className={styles.labelRow}>
<span className={styles.label}>{label}</span>
<button
onClick={copyToClipboard}
disabled={copyStatus === 'copying'}
className={getButtonClass()}
aria-label={`Copy ${label.toLowerCase()}`}
>
{getButtonText()}
</button>
</div>
<div className={styles.urlRow}>
<input
type="text"
value={url}
readOnly
className={styles.urlInput}
onClick={(e) => e.currentTarget.select()}
/>
</div>
<button
onClick={copyToClipboard}
disabled={copyStatus === 'copying'}
className={getButtonClass()}
aria-label={`Copy ${label.toLowerCase()}`}
>
{getButtonText()}
</button>
</div>
)
}
Expand Down
38 changes: 8 additions & 30 deletions src/apps/golf/components/__tests__/PermalinkDisplay.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@ describe('PermalinkDisplay', () => {
describe('Rendering', () => {
it('renders the component with label and URL', () => {
render(<PermalinkDisplay {...defaultProps} />)

expect(screen.getByText('Share Room')).toBeInTheDocument()
expect(screen.getByDisplayValue('https://example.com/golf/room/ABC123')).toBeInTheDocument()
expect(screen.getByRole('button', { name: /copy share room/i })).toBeInTheDocument()
})

Expand All @@ -57,26 +56,18 @@ describe('PermalinkDisplay', () => {
label: 'Share Game',
url: 'https://example.com/golf/room/ABC123/game/XYZ789'
}

render(<PermalinkDisplay {...customProps} />)

expect(screen.getByText('Share Game')).toBeInTheDocument()
expect(screen.getByDisplayValue('https://example.com/golf/room/ABC123/game/XYZ789')).toBeInTheDocument()
expect(screen.getByRole('button', { name: /copy share game/i })).toBeInTheDocument()
})

it('renders copy button with initial text', () => {
render(<PermalinkDisplay {...defaultProps} />)

const copyButton = screen.getByRole('button', { name: /copy share room/i })
expect(copyButton).toHaveTextContent('Copy Link')
})

it('renders URL input as readonly', () => {
render(<PermalinkDisplay {...defaultProps} />)

const urlInput = screen.getByDisplayValue(defaultProps.url)
expect(urlInput).toHaveAttribute('readonly')
const copyButton = screen.getByRole('button', { name: /copy share room/i })
expect(copyButton).toHaveTextContent('Share Room')
})
})

Expand All @@ -100,7 +91,7 @@ describe('PermalinkDisplay', () => {

// Wait for reset
await waitFor(() => {
expect(copyButton).toHaveTextContent('Copy Link')
expect(copyButton).toHaveTextContent('Share Room')
}, { timeout: 3000 })
})

Expand Down Expand Up @@ -132,7 +123,7 @@ describe('PermalinkDisplay', () => {

// Wait for reset
await waitFor(() => {
expect(copyButton).toHaveTextContent('Copy Link')
expect(copyButton).toHaveTextContent('Share Room')
}, { timeout: 3000 })
})
})
Expand Down Expand Up @@ -261,24 +252,11 @@ describe('PermalinkDisplay', () => {

// Wait for the timeout to reset the button
await waitFor(() => {
expect(copyButton).toHaveTextContent('Copy Link')
expect(copyButton).toHaveTextContent('Share Room')
}, { timeout: 3000 })
})
})

describe('URL Input Interactions', () => {
it('selects all text when URL input is clicked', () => {
render(<PermalinkDisplay {...defaultProps} />)

const urlInput = screen.getByDisplayValue(defaultProps.url) as HTMLInputElement
const selectSpy = vi.spyOn(urlInput, 'select')

fireEvent.click(urlInput)

expect(selectSpy).toHaveBeenCalled()
})
})

describe('Accessibility', () => {
it('has proper aria-label for copy button', () => {
render(<PermalinkDisplay {...defaultProps} />)
Expand Down