[blocked on failing tests] Add Nix Flake and formatters#32
Draft
remo5000 wants to merge 5 commits into
Draft
Conversation
Is this even required? Why is taplo-cli commented out in erg?
Owner
|
The reason the test fails because the test requires pylyzer to be installed before it run. |
mtshiba
force-pushed
the
main
branch
6 times, most recently
from
September 10, 2023 06:10
6389bf6 to
965418b
Compare
mtshiba
force-pushed
the
main
branch
2 times, most recently
from
August 21, 2024 03:20
9a4a687 to
18af09b
Compare
mtshiba
force-pushed
the
main
branch
5 times, most recently
from
September 3, 2024 08:17
345b832 to
31d7ad4
Compare
mtshiba
force-pushed
the
main
branch
3 times, most recently
from
February 6, 2025 10:14
074d01c to
acd5099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I wanted to build pylyzer on my local machine, so I copied the nix flake from the erg repo. Let me know if you prefer a solution where we re-use the flake from erg or something.
I've taken the liberty to format all the files using
treefmt-- I noticed that some of the formatters are commented out on erg so please let me know if you want just the flake without taplo-cli, rustfmt, treefmt and the formatted files.Build works:
Test fails, it seems to be related to how modules get imported. I printed out the errors for the import.py test, will look into fixing them