Reyna/reyna

[reynabiyo20]

No description provided.

[kellydobbs]

Hey Renya! Here are the issues that I found:

1. The category drop-down only has the "All Categories" option but not the other categories on "recipes/display" and "recipes"
2. Re-add "/about" to the whitelist
3. Clicking the "filter" button without selecting any filters produces an error because no tagId is being passed into the model.
4. If you apply a filter then try to sort the results, the selected filters are removed and it sorts all recipes in a category, rather than just those that meet the filter criteria.
5. Do you think that it would be best to just comment out the "sort by time" option until we add a new field for it?

---

I also found these two errors related to bootstrap and the User class. They're working in the current master. It looks like your branch is fully up to date with the master, so I'm not certain what the cause is. @paalwilliams , could you take a look too?

1. Clicking on the shopping cart icon produces an error
2. On "recipes/all," trying to add a recipe to your shopping cart causes an error

class java.lang.String cannot be cast to class org.launchcode.recipeapp.models.User (java.lang.String is in module java.base of loader 'bootstrap'; org.launchcode.recipeapp.models.User is in unnamed module of loader org.springframework.boot.devtools.restart.classloader.RestartClassLoader @7af21160)

---

Then there are the things we talked about earlier, but those could wait for another pull request!

There was a lot added in this pull request, so I'd love it someone else could give it a look over as well!

[reynabiyo20]

Thank you for your feedback, Kelly! I’m still working on some errors you found.

…

On Sun, Jan 31, 2021 at 5:56 PM Kelly Dobbs ***@***.***> wrote: Hey Renya! Here are the issues that I found: 1. The category drop-down only has the "All Categories" option but not the other categories on "recipes/display" and "recipes" 2. Re-add "/about" to the whitelist 3. Clicking the "filter" button without selecting any filters produces an error because no tagId is being passed into the model. 4. If you apply a filter then try to sort the results, the selected filters are removed and it sorts all recipes in a category, rather than just those that meet the filter criteria. 5. Do you think that it would be best to just comment out the "sort by time" option until we add a new field for it? ------------------------------ I also found these two errors related to bootstrap and the User class. They're working in the current master. It looks like your branch is fully up to date with the master, so I'm not certain what the cause is. @paalwilliams <https://github.com/paalwilliams> , could you take a look too? 1. Clicking on the shopping cart icon produces an error 2. On "recipes/all," trying to add a recipe to your shopping cart causes an error class java.lang.String cannot be cast to class org.launchcode.recipeapp.models.User (java.lang.String is in module java.base of loader 'bootstrap'; org.launchcode.recipeapp.models.User is in unnamed module of loader org.springframework.boot.devtools.restart.classloader.RestartClassLoader @7af21160) ------------------------------ Then there are the things we talked about earlier, but those could wait for another pull request! There was a lot added in this pull request, so I'd love it someone else could give it a look over as well! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQCFRNDKHMIKJ7TWOVULXTLS4XUZVANCNFSM4W3XSKEA> .