Hughes and Jablonowski baroclinic topo test#9
Open
mt5555 wants to merge 2 commits into
Open
Conversation
fix nlevp overflow fix bug in pressure init ( signficiant ) make w_i continuous at element edges add namelist for this test pressure init bug also required turning on theta_advect_form=1 shift longitude of mountains to be over CONUS
mt5555
pushed a commit
that referenced
this pull request
Jan 16, 2026
…t#7866) This is changing code that is widely used and has been unchanged for a very long time, so I'm adding a lot of reviewers. Feel free to add more. I stumbled across this code when trying to debug a weird eamxx failure: I observed the following symtoms: If you look at components/elm/src/main/reweightMod.F90, you'll see the line SHR_ASSERT(bounds%level == BOUNDS_LEVEL_CLUMP, errMsg(__FILE__, __LINE__)) which causes this error: 1: free(): invalid pointer ... 0: #8 0x4c7e3ab in __shr_log_mod_MOD_shr_log_errmsg 0: at /pscratch/sd/a/acmetest/E3SM/share/util/shr_log_mod.F90:78 0: #9 0x914149 in __reweightmod_MOD_reweight_wrapup 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/main/reweightMod.F90:48 0: E3SM-Project#10 0x17bda7d in __dynsubgriddrivermod_MOD_dynsubgrid_wrapup_weight_changes 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/dyn_subgrid/dynSubgridDriverMod.F90:403 0: E3SM-Project#11 0x17bf256 in __dynsubgriddrivermod_MOD_dynsubgrid_init._omp_fn.0 0: at /pscratch/sd/a/acmetest/E3SM/components/elm/src/dyn_subgrid/dynSubgridDriverMod.F90:150 I thought this was because the SHR_ASSERT was failing, but that's not the case (both bounds%level and BOUNDS_LEVEL_CLUMP are always 2). If I just comment this SHR_ASSERT out entirely, the test PASSES! The lowest line of code that triggers the free(): invalid pointer error is: shr_log_errMsg = 'ERROR in '//trim(file)//' at line '//toString(line) What I think is happening is that there is some memory corruption that is causing the freeing of the allocation done by toString to fail. So, this PR kind of sweeps that issue under the rug, but I do think it's better not to do dynamic allocations if you don't have to. The test PASSes with the changes in this PR. [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.