Add post-publish verify step (real install + import)#6
Open
mstorath wants to merge 1 commit into
Open
Conversation
Mirrors CMF v0.1.7's post-publish smoke check (devcontainer reports/11-cmf-v0.1.7-release.md). PyPI accepting the upload is not the same as `pip install` working — the new step does a real `pip install dcebe` from PyPI, imports the module, and asserts `estimate_bat` is exposed. DCEBE's first release will exercise this. The import alone proves the wheel installs and the C++ binding loads; a representative `estimate_bat(...)` smoke call can be added once the public API is finalised in the port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a post-publish smoke check to the publish job: after
gh-action-pypi-publishfinishes, the workflow does a realpip install dcebefrompypi.org/simple/, imports the module, and assertsestimate_batis exposed on the public API.DCEBE's first release will exercise this. The import alone proves the wheel installs and the C++ binding loads; a representative
estimate_bat(...)call can be added later once the public API is fully finalised in the ongoing port.PyPI accepting the upload is not the same as `pip install` working. The check catches:
__init__.pyMirrors the step that landed in
CircleMedianFilterduring v0.1.7. Same backport landing in parallel for Pottslab, CSSD, L1TV.Test plan
v*.*.*tag push that ships DCEBE.estimate_bat(...)smoke call.