Drop stale 'Template' headers from CI workflows#12
Open
mstorath wants to merge 1 commit into
Open
Conversation
Both .github/workflows/ci.yml and .github/workflows/release.yml had '# Template — copy to ...' header comments left over from the port-to-PyPI cycle, even though both files are now active production workflows that have been firing on every push and tag. release.yml also had a stale comment claiming 'DCEBE doesn't have a CHANGELOG.md yet'; CHANGELOG.md was added in v1.0.0 and is the source of release-notes text. Comment-only edits; no change to triggers, jobs, secrets, or runtime behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
.github/workflows/ci.ymland.github/workflows/release.ymlhad# Template — copy to ...headers left over from when the workflows were drafted in the port-to-PyPI cycle. Both files are now active production workflows firing on every push and tag, so the "Template" framing is misleading.release.ymlalso had a stale comment claiming "DCEBE doesn't have a CHANGELOG.md yet"; CHANGELOG.md was added in v1.0.0 and is the active source of release-notes text.Changes
ci.yml: remove the 5-line Template-header block; keep the brief "Pure-Python pytest matrix" line.release.yml: remove the 5-line Template-header block; keep the "Tag-gated PyPI publication via OIDC" description.release.ymlstep comment: rewrite to describe the fallback behaviour without referencing the now-obsolete "no CHANGELOG.md" state.Test plan
Comment-only edits — no triggers, jobs, secrets, or step bodies change.
ci.ymldiff: 6 lines removed, 1 line added (just the brief description).release.ymldiff: 7 lines removed, 5 lines rephrased —name:,on:,jobs:,steps:blocks unchanged.