Add watchOS support#1
Open
lumiasaki wants to merge 1 commit into
Open
Conversation
lumiasaki
force-pushed
the
feature/add_watchos_support
branch
from
c2752c3 to
fa5cf10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @mstfy!
While working with some prominent third-party libraries like Realm that offer watchOS instruction set libraries, I noticed that xctrim currently doesn't recognize them. This observation motivated me to enhance xctrim by adding support for watchOS.
Changes Made:
watchOS Recognition: The xctrim can now recognize and process frameworks targeting watchOS.
I've tested these changes with several xcframeworks that include watchOS support, and the results were as expected. The tool successfully trimmed unnecessary architectures.
I hope you find these changes valuable. I'm open to feedback and would be happy to make any necessary adjustments.
Thank you for considering this pull request!