test: update stale orpheus modular test to the decode_finished contract - #205
Open
vasilevklart wants to merge 1 commit into
Open
test: update stale orpheus modular test to the decode_finished contract#205vasilevklart wants to merge 1 commit into
vasilevklart wants to merge 1 commit into
Conversation
The prefill-transition test predates the dynamic loop-stop: the model no longer seeds audio_token_count/decode_finished kwargs at the prefill->decode transition (decode_finished is set only at loop exit). Assert the current contract instead; drop the dead audio_token_count input and an unused helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefill transition test fails on clean main with
KeyError: 'audio_token_count'(test/modular/test_orpheus_model.py:38)Looks like the test predates the dynamic loop stop, the model doesnt seed
audio_token_count/decode_finishedkwargs at the prefill->decode transition anymore..decode_finishedonly gets set when the loop exits (orpheus_model.py:240). So I updated the assertions to the current contract (transition leaves kwargs untouched, request not done) and dropped the deadaudio_token_countinput plus an unused helper.Before: 1 failed 1 passed -> after: 2 passed with
pytest test/modular/test_orpheus_model.pyPart of the bigger suite drift in #132 , just fixing the file the adding models doc points you at first