forked from Heinze-lab/EMalign
-
Notifications
You must be signed in to change notification settings - Fork 0
Add SBEM stage-position XY alignment option #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msayr
wants to merge
1
commit into
sbem_image
Choose a base branch
from
codex/add-alignment-feature-for-sbem_image-mode
base: sbem_image
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import numpy as np | ||
| from emalign.align_xy.stitch_ongrid import _apply_tile_origin_offsets | ||
|
|
||
|
|
||
| def test_apply_tile_origin_offsets_converts_origins_to_sofima_offsets(): | ||
| tile_map = { | ||
| (0, 0): np.zeros((100, 200), dtype=np.uint8), | ||
| (1, 0): np.zeros((100, 200), dtype=np.uint8), | ||
| (0, 1): np.zeros((100, 200), dtype=np.uint8), | ||
| } | ||
| cx = np.zeros((2, 1, 2, 2), dtype=float) | ||
| cy = np.zeros((2, 1, 2, 2), dtype=float) | ||
| tile_origins = { | ||
| (0, 0): (0, 0), | ||
| (1, 0): (3, 180), | ||
| (0, 1): (90, -4), | ||
| } | ||
|
|
||
| cx, cy = _apply_tile_origin_offsets(cx, cy, tile_map, tile_origins) | ||
|
|
||
| assert cx[0, 0, 0, 0] == -20 | ||
| assert cx[1, 0, 0, 0] == 3 | ||
| assert cy[0, 0, 0, 0] == -4 | ||
| assert cy[1, 0, 0, 0] == -10 | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this option is used through
sbem_image,tile_originsis keyed byparse_yx_pos_from_name, which returns(row, col)(for example the SBEM tests expect an upper-right tile at(0, 1)). This loop unpacks those keys as(x, y), so a real right neighbor at(0, 1)is treated asdownand its horizontal stage delta is written intocyinstead ofcx, producing a transposed/incorrect coarse mesh for SBEM rows with more than one tile. Convert the SBEM keys to the internal(x, y)convention before applying stage offsets, or unpack/index them consistently as(y, x)here.Useful? React with 👍 / 👎.