Allow a function as lengths in tree-generation functions#273
Merged
Conversation
`RandomTree()`, `YuleTree()`, `PectinateTree()`, `BalancedTree()`, `StarTree()`, and `SingleTaxonTree()` now accept a function for the `lengths` argument; the function is called with the number of edges as its sole argument, e.g. `RandomTree(8, lengths = runif)`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 96.19% 96.18% -0.01%
==========================================
Files 81 81
Lines 6039 6033 -6
==========================================
- Hits 5809 5803 -6
Misses 230 230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Performance benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RandomTree(),YuleTree(),PectinateTree(),BalancedTree(),StarTree(), andSingleTaxonTree()now accept a function as thelengthsargument; the function is called with the number of edges as its sole argument.RandomTree(8, lengths = runif)instead ofRandomTree(8, lengths = runif(14))..EdgeLengths(lengths, nEdge)consolidates the dispatch (function vs vector) across all six functions.GenerateTree.RdandTrivialTree.Rdregenerated); exampleRandomTree(8, lengths = runif)added.seq_len-based assertions that verify the function is called with the exact edge count.Test plan
devtools::test(filter = "tree_generation")— 121 tests, 0 failuresman/GenerateTree.Rdandman/TrivialTree.Rdfor updatedlengthsdescription🤖 Generated with Claude Code