Skip to content

fix: resolve lint and mypy errors in sys_utils_nixos.py#6

Open
mrosseel wants to merge 27 commits into
mainfrom
fix/sys-utils-nixos-ci
Open

fix: resolve lint and mypy errors in sys_utils_nixos.py#6
mrosseel wants to merge 27 commits into
mainfrom
fix/sys-utils-nixos-ci

Conversation

@mrosseel
Copy link
Copy Markdown
Owner

Summary

  • Fix Ruff linting errors in sys_utils_nixos.py (unused imports, line length)
  • Fix mypy type errors by adding proper type annotations and handling Optional types
  • Update pyproject.toml to include sys_utils_nixos in mypy overrides

Test plan

  • nox -s lint passes
  • nox -s type_hints passes
  • Verify sys_utils_nixos functionality on NixOS

🤖 Generated with Claude Code

mrosseel and others added 27 commits March 17, 2025 22:19
This reverts commit c872394.
The SD image module provides filesystems, but toplevel builds need
a minimal stub to evaluate successfully.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for NixOS module system to accept devMode setting.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required when module has both options and config sections.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replaces FIXME placeholders with actual SRI hashes.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Uses Pi5 runner when RUNNER_LABELS variable is set, falls back to
ubuntu with QEMU emulation otherwise.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Filter to only Pi 4B device tree (CM4 incompatible with our overlays)
- Use shorthand DTS syntax for PWM overlay

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix E402 lint: reorder gi imports, add noqa for gi.repository
- Fix Python 3.10 syntax: dict | None → Optional[dict]
- Fix utils.pifinder_home → utils.home_dir / "PiFinder"
- Add dbus/gi to mypy ignore list (no type stubs available)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mrosseel pushed a commit that referenced this pull request May 25, 2026
…+ FAQ consolidation (brickbots#439)

* Strengthen Quick Start focus guidance and update Catalogs page

Quick Start (item #2): focus is the most common reason solving fails, so
lead the Setting Focus section with that, stress zooming to 2x/4x to judge
star tightness, give a ~6mm-of-thread starting position, and add high-thin
cloud plus the AUTO-exposure (2.2.x caveat) to the troubleshooting note.
Cross-link to the new Troubleshooting page.

Catalogs (item #6): add the missing TLK (variable stars) and Lyn (Lyngå
open clusters) catalogs, correct the WDS pair count to 130,000+ to match
the shipped database, and document finding large catalogs by Name Search
or Nearest sorting.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Make docs skill voice guidance more formal

Shift the house-voice guidance from "encouraging and a little excited"
toward warm but measured, reserve exclamation points, and add a rule to
never open a sentence with a conjunction (And/But/So). Bring the skill's
own prose into line with that rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Show off-center alignment reticle in Quick Start (item #3)

Add a note to the Alignment section stating the Telrad-style reticle marks
where the scope points within the camera's 10° field of view and will not be
centered, which is normal. Re-capture all four alignment demo images on a
single consistent star field so the reticle is clearly off-center and the
flow reads coherently.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Add gamma mid-tone lift to screenshot_to_doc converter

Dim elements like the title bar text were hard to read after the linear
amber recolor. Add a --gamma step (default 1.5, >1 brightens) applied to the
intensity before recoloring so screenshots stay legible at doc size.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Expand SkySafari page with usage and troubleshooting (item #5)

Add a "Using SkySafari" section (follow scope on chart, send targets; the
single-connection limit; no GoTo slew or simultaneous GoTo-mount yet; sleep
mode stops updates) and a "Troubleshooting" section (PiFinderAP
auto-disconnect, .local -> numeric IP, no position until first solve,
same-SSID interference) to the otherwise setup-only page.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Improve software-update discoverability and re-flash notes (item #8)

In the Update Software section, reassure that updates happen on-device (no
mail-in; units often ship a version or two behind) and explain that an
"unknown" version means no internet rather than a reason to re-image. In the
software setup page, note that a "not a multiple of 512 bytes" write error
means a corrupted/partial download.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Consolidate the user-guide FAQ into the Troubleshooting & FAQ page

The user guide carried a separate FAQ (EQ mount, motorized-mount control,
GPS/chrony system clock) duplicating the role of the new Troubleshooting &
FAQ page. Move those three questions onto troubleshooting.rst in its
bold-question style (code blocks preserved) and replace the user-guide FAQ
section with a pointer so there is a single FAQ.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant