Harden KVM input and local video recovery#196
Merged
mrjeeves merged 2 commits intoJul 26, 2026
Conversation
mrjeeves
marked this pull request as ready for review
July 26, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
KVM sources consume absolute pointer coordinates, while pointer lock emits relative movement. Native H.264 decoding could also remain wedged when NVDEC accepted input without returning pictures. Backend recovery needed explicit process ownership so a GUI recovery attempt could not terminate an external or service-owned node.
CEC Support's Windows service runs as LocalSystem in Session 0. Its pinned node helper previously reused any node that answered or spawned a new child in the caller's session. The helper now permits a Session 0 service to reuse an existing interactive node, rejects a Session 0 node, and refuses to create a media/input host when the caller is in Session 0.
Scope
This PR changes AllMyStuff only. It does not include the separate CEC Support, NanoKVM, or NanoKVM-Pro work.
The decoder preference and Windows process/session checks are local process IPC. No peer protocol schema, signaling, discovery, rendezvous, SDP, ICE, STUN, or TURN behavior is changed.
This PR does not mark the GUI or node as
requireAdministrator. Elevation needs a secured interactive worker and local IPC boundary. A manifest-only change would make startup UAC-dependent and expose the elevated node through the current same-user control pipe.Validation
cargo test -j 16innode: 215 passedcargo clippy --all-targets -j 16 -- -D warningsinnodecargo check --no-default-features --features host -j 16innodecargo test -j 16ingui/src-tauri: 7 passedcargo fmt --all -- --checkin both Rust workspacesnpm run check: 0 errors and 0 warningsnpm run build