Skip to content

fix: use Split limit 2 to handle titles containing pipe characters #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Noethix55555 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use Split limit 2 to handle titles containing pipe characters #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804efe8
fix: guard minimum-aspect-ratio parsing against FormatException
Noethix55555 Jun 18, 2026
d6b2412
fix: use Split limit 2 to handle titles containing pipe characters
Noethix55555 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/MpvNet/App.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ public bool ProcessProperty(string name, string value, bool writeError = false)
case "light-theme": LightTheme = value.Trim('\'', '"'); return true;
case "media-info": MediaInfo = value == "yes"; return true;
case "menu-syntax": MenuSyntax = value; return true;
case "minimum-aspect-ratio-audio": MinimumAspectRatioAudio = value.ToFloat(); return true;
case "minimum-aspect-ratio": MinimumAspectRatio = value.ToFloat(); return true;
case "minimum-aspect-ratio-audio": if (float.TryParse(value.Replace(",", "."), System.Globalization.NumberStyles.Float, System.Globalization.CultureInfo.InvariantCulture, out var mar2)) MinimumAspectRatioAudio = mar2; return true;
case "minimum-aspect-ratio": if (float.TryParse(value.Replace(",", "."), System.Globalization.NumberStyles.Float, System.Globalization.CultureInfo.InvariantCulture, out var mar)) MinimumAspectRatio = mar; return true;
case "process-instance": ProcessInstance = value; return true;
case "queue": Queue = value == "yes"; return true;
case "recent-count": RecentCount = value.ToInt(15); return true;
Expand All @@ -163,7 +163,7 @@ public static (string Title, string Path) GetTitleAndPath(string input)
{
if (input.Contains('|'))
{
var a = input.Split('|');
var a = input.Split('|', 2);
return (a[1], a[0]);
}

Expand Down