Patch autosave issue caused by summernote issue / Cleanup hacky code#24
Open
daniellmorris wants to merge 4 commits into
Open
Patch autosave issue caused by summernote issue / Cleanup hacky code#24daniellmorris wants to merge 4 commits into
daniellmorris wants to merge 4 commits into
Conversation
Add comment explaining why we are setting the value field
Make so there is no error if template is added directly as a template without the use of autoform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches an issue with autosave. When i would highlight text and then change font size autosave would stop working. The value was not being updated from summernote. Now I force the value to be set before triggering a change that autform will detect.
Use onRendered instead of rendered = function() {}
Remove hacky code and detect data context change the right way.