Lateania: make city districts walkable (you couldn't move between district rooms)#401
Open
hardlygospel wants to merge 1 commit into
Open
Conversation
Each capital's district was a hub-and-spoke: a spine room fanned out to
four haunts, and every haunt had a single exit back to the spine. So
from a room like the Stonecutters' Court you could only go back the way
you came ("You can't go west"), never move between the haunts.
Lay each district out as a walkable street instead: the spine faces the
square and the four haunts run off it along one axis, chained to each
other, preferring an east-west run. Now you stroll through them and back.
Adds a regression test that each district's rooms link to a sibling (a
street), not just dead-end at the spine.
cargo test / clippy / fmt green.
Signed-off-by: Tony Hosaroygard <tasmaniamate@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @mpiorowski! A follow-up bugfix for the city districts that shipped in The Wide World (#386).
The bug
Each capital's district was a hub-and-spoke: a spine room fanned out to four "haunts", and every haunt had a single exit back to the spine. So standing in, say, the Stonecutters' Court you could only go back the way you came — hence the wall of "You can't go west." You could never move between the haunts, only in-and-out through the hub.
The fix
Lay each district out as a walkable street: the spine faces the square, and the four haunts run off it along one axis, chained to each other (preferring an east-west run). Now you stroll down the street through them and back. Applies to all four capitals (Lamplit Quarter, Saltwind Wharves, Hightarn Terraces, Sunbaked Bazaar) from the one generator.
Regression test
Adds
city_districts_are_a_walkable_street_not_dead_end_rooms, asserting each district's rooms link to a sibling haunt (a street), not merely dead-end at the spine — which the old star failed.Branched off current
main; touches onlyworld.rs.