refactor(recyclarr): switch to includes pattern for resilient CF management#720
Open
mpeterson wants to merge 1 commit into
Open
refactor(recyclarr): switch to includes pattern for resilient CF management#720mpeterson wants to merge 1 commit into
mpeterson wants to merge 1 commit into
Conversation
…gement Replace fragile custom_format_groups + select pattern with recyclarr's include templates. The templates are maintained upstream and automatically track TRaSH Guides reorganizations, preventing breakage like the one fixed in PR #719. - Use official sonarr/radarr include templates for standard CFs - Add optional CFs (SDR, IMAX Enhanced, etc.) as direct custom_formats - Remove all custom_format_groups references Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the fragile
custom_format_groups+selectpattern with recyclarr's upstream-maintained include templates. This eliminates the coupling to TRaSH Guides' CF group organization, which caused the CronJob breakage fixed in #719.What changed
Added
include:directives for official recyclarr config templates:radarr-quality-definition-movie,sonarr-quality-definition-series)radarr-quality-profile-{uhd,hd}-bluray-web,sonarr-v4-quality-profile-web-{2160p,1080p})radarr-custom-formats-{uhd,hd}-bluray-web,sonarr-v4-custom-formats-web-{2160p,1080p})Removed all
custom_format_groups(Golden Rule UHD/HD, HDR Formats, Optional groups)Added direct
custom_formats:entries for optional CFs not covered by includes:Removed explicit
quality_profiles:withtrash_idreferences andquality_definition:sections — both are now provided by includesWhy
The
custom_format_groupspattern couples config to TRaSH Guides' internal group organization. When TRaSH reorganizes groups (moving CFs between groups, renaming groups), theselectreferences break. This happened recently and was fixed in #719.The includes pattern uses direct CF
trash_idsmaintained by the recyclarr project. When TRaSH reorganizes, the recyclarr maintainers update the templates — our config doesn't need to change.Preserved behavior
delete_old_custom_formats: truebehavior