Include Full Apache-2.0 License text#1010
Open
bohemian-miser wants to merge 1 commit into
Open
Conversation
Section 4.a. of the Apache 2.0 license, states that a full copy of the license needs to travel with the software whenever it is redistributed. I pointed this out in the previous pull request, but the PR was already closed and ignored mozilla#1009 The confusion came from the appendix regarding license headers in source code and was misread as applying to the project.
gijsk
requested changes
May 14, 2026
Contributor
gijsk
left a comment
gijsk
left a comment
There was a problem hiding this comment.
Thanks for the renewed PR.
For context, I did not intentionally ignore your PR or comments, I have simply been busy and didn't get around to yours yet.
My understanding here is that if we're updating things, ideally the LICENSE file should contain the contents of https://www.apache.org/licenses/LICENSE-2.0.txt verbatim with no changes, and a NOTICE file should be used to include copyrights (instead of leaving them at the top of the license file).
Would you mind updating the PR accordingly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 4.a. of the Apache 2.0 license, states that a full copy of the license needs to travel with the software whenever it is redistributed.
I pointed this out in the previous pull request, but the PR was already closed and ignored #1009
The confusion came from the appendix regarding license headers in source code and was misread as applying to the project.