Skip to content

Improve contrast and readability with light theme#4256

Closed
flodolo wants to merge 5 commits into
mozilla:mainfrom
flodolo:issue4206
Closed

Improve contrast and readability with light theme#4256
flodolo wants to merge 5 commits into
mozilla:mainfrom
flodolo:issue4206

Conversation

@flodolo

@flodolo flodolo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #4206

@flodolo flodolo requested review from ayshushus and mathjazz June 24, 2026 10:54
@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.00%. Comparing base (6727ff3) to head (2fbf8a8).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flodolo

flodolo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

I left a temporary folder with screenshots. If you look at the last commit 1bcb33d (this PR) you should be able to use the Swipe mode to see the difference before/after.

Mostly:

  • Darker gray and green for translation statuses
  • Darker gray for disabled chart categories (now almost invisible)
  • Also fixed theme switching on charts

@ayshushus

Copy link
Copy Markdown
Collaborator

i like it alot! just a few things:

between light and system, the bar is missing (happened in my PR as well 😅):
Screenshot 2026-06-24 at 11 30 29

error color is lighter here:
Screenshot 2026-06-24 at 11 42 41
and here:
Screenshot 2026-06-24 at 11 41 55

would we want to make the greens similar? here for example:
Screenshot 2026-06-24 at 11 52 11(1)

i think we should change this, RGB is still off, it's a fuzzy string, e.g. /af/amo/LC_MESSAGES/djangojs.po/?extra=fuzzy&string=190758
Screenshot 2026-06-24 at 12 02 10

@flodolo flodolo marked this pull request as draft June 24, 2026 17:28
@flodolo

flodolo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the review. Turns out I'm introducing inconsistency in a ton of places.

Setting this back to draft, and running locally a bit longer.

@flodolo

flodolo commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

I'm going to close this PR to avoid noise, and likely open one from a different branch when I feel it's ready.

At this point I'm making several design choices on color, so it might require a different discussion.

@flodolo flodolo closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve accessibility and contrast of light theme

3 participants