Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

jsctags works with nodejs 0.10.x again.#54

Open
tow8ie wants to merge 1 commit into
mozilla:masterfrom
tow8ie:nodejs-0.10.x-compatibility
Open

jsctags works with nodejs 0.10.x again.#54
tow8ie wants to merge 1 commit into
mozilla:masterfrom
tow8ie:nodejs-0.10.x-compatibility

Conversation

@tow8ie

@tow8ie tow8ie commented Apr 19, 2013

Copy link
Copy Markdown

The issue #52 by @doovoochild has been closed, but the fix described by @chilkari in the discussion hasn’t been patched into master. Here is this patch.

Applied patch as described in
mozilla#52.
@renovatorruler

Copy link
Copy Markdown

I second this pull request. Just applied the patch to mozilla/doctorjs and jsctags works beautifully.

@chilkari

Copy link
Copy Markdown

Thanks, tow8le. I should have put a real patch together. Thanks for submitting. Naturally, it worked for me, so if this is helpful to others, I also support request.

@prasincs

Copy link
Copy Markdown

Worked for me too. Definitely supported.

@thatguydan

Copy link
Copy Markdown

+1

2 similar comments
@dmcinnes

dmcinnes commented Jun 4, 2013

Copy link
Copy Markdown

👍

@lancelotj

Copy link
Copy Markdown

+1

@mitermayer

Copy link
Copy Markdown

+1 please merge that

@tosyu

tosyu commented Jun 18, 2013

Copy link
Copy Markdown

+1

@sangwook-kim

Copy link
Copy Markdown

+1.

I should have kept this issue opened. Sorry.

@kredmer

kredmer commented Jun 19, 2013

Copy link
Copy Markdown

+1

1 similar comment
@pose

pose commented Jun 25, 2013

Copy link
Copy Markdown

👍

@jojojames

Copy link
Copy Markdown

Another +1 here.

@qzg

qzg commented Jun 29, 2013

Copy link
Copy Markdown

+1 Works.

@wlaurance

Copy link
Copy Markdown

👍

@iammerrick

Copy link
Copy Markdown

Please?

@mitermayer

Copy link
Copy Markdown

@tow8ie i would update this pull to this:

 exports.Tags = function (initialTags) {
     this.tags = initialTags || this.tags;
     this.init();
 };

 exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({
        tags: [],

The reason why i would do that is because you would still allow Tags to be instantiated using an array of initial tags, maybe doing that would get them this pull finaly merged

@francoisjacques

Copy link
Copy Markdown

@mitermayer approach works well while respecting the initialTags case.

@tony

tony commented Dec 23, 2013

Copy link
Copy Markdown

@mozilla Hey, if anyone is an administer over here - there hasn't been any movement here in a while, can we have a status report on this package? This is an important package to a lot of people. Thanks.

@baongoc124

Copy link
Copy Markdown

+1

@michelalbers

Copy link
Copy Markdown

👍 +1

@kalinichenko

Copy link
Copy Markdown

+1

@leostratus

Copy link
Copy Markdown

Will it help if a Mozillian gets a +1 in here? I'm getting questions about this PR and this isn't even a project I work on. HEYOOOO can we get a merge all up in this?

+1

@sKatsuya

sKatsuya commented Mar 7, 2014

Copy link
Copy Markdown

great! 👍

@Salles-FA

Copy link
Copy Markdown

+1

@mitermayer

Copy link
Copy Markdown

I was wondering, if depending the license we could all fork it up and continue its development since it looks like this is not getting merged any time soon

@yang-ling

Copy link
Copy Markdown

This project needs new leadership.
DoctorJS looking for new leadership

@rocknrollMarc

Copy link
Copy Markdown

Ive installed jsctags on like 4 new machienes and had to do this quickfix everytime why dont you update the code? Is there a good reason for that?

exports.Tags = function (initialTags) {
this.tags = initialTags || this.tags;
this.init();
};

exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({
tags: [],

Every kind of newbie is going to loose his hair, I remember I nearly did.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.