fix: guard against KeyError in get_priority_change_date by using .get()#2901
Open
AmSach wants to merge 1 commit into
Open
fix: guard against KeyError in get_priority_change_date by using .get()#2901AmSach wants to merge 1 commit into
AmSach wants to merge 1 commit into
Conversation
The change history entries may not always contain 'field_name' or 'added' keys, causing a KeyError when iterating through bug history. Using .get() with None default prevents the crash while preserving the original logic: only entries with field_name=='priority' and matching added value are used. Fixes mozilla#2607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug described in issue #2607. Here's what was wrong and how I fixed it: In get_priority_change_date(), the code directly accessed change['field_name'] and change['added'] without checking if those keys exist, causing KeyError on malformed history entries. Fixed by using .get() with None defaults. Tested by verifying syntax with ast.parse().