Skip to content

Preserve AAGUID in AttestationObject::anonymize#357

Merged
jschanck merged 2 commits into
mozilla:ctap2-2021from
jschanck:preserve-aaguid
May 27, 2026
Merged

Preserve AAGUID in AttestationObject::anonymize#357
jschanck merged 2 commits into
mozilla:ctap2-2021from
jschanck:preserve-aaguid

Conversation

@jschanck
Copy link
Copy Markdown
Collaborator

Updates our behavior to match Step 3 of the "If any authenticator returns success" branch of WebAuthn 5.1.3.22:

If the aaguid in the attested credential data is 16 zero bytes, credentialCreationData.attestationObjectResult.fmt is "packed", and "x5c" is absent from credentialCreationData.attestationObjectResult, then self attestation is being used and no further action is needed.
Otherwise:
Set the value of credentialCreationData.attestationObjectResult.fmt to "none", and set the value of credentialCreationData.attestationObjectResult.attStmt to be an empty CBOR map.

Previously we additionally zeroed the AAGUID when it was present. We also did not implement the self-attestation exemption.

@jschanck jschanck requested a review from mozkeeler May 26, 2026 20:17
Copy link
Copy Markdown
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jschanck jschanck force-pushed the preserve-aaguid branch 3 times, most recently from 74332f7 to d40662e Compare May 27, 2026 18:18
@jschanck jschanck merged commit c3bd4b6 into mozilla:ctap2-2021 May 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants