Bug 2047013 - Allows rating of summarizations#303
Conversation
boek
commented
Jun 23, 2026
boek
commented
|
Warning The base branch is currently set to |
|
View this pull request in Lando to land it once approved. |
|
When you rate: |
|
https://addons.mozilla.org/en-US/firefox/ {
"detail": "You do not have permission to perform this action."
} |
There was a problem hiding this comment.
| * @param onFeedbackClicked Invoked when the user rates the summary. When `null`, the feedback |
There was a problem hiding this comment.
nit: can we add some spacing between each of these composables to make it easier to read
There was a problem hiding this comment.
Hmm can you explain why we have this if branch? I'm probably missing something but I don't really get why we need it
There was a problem hiding this comment.
I think it could make sense for this to be here. It could also make sense to add an entirely new middleware for this, since we seem to just be leveraging our telemetry system to measure this non telemetry event. Let me know what your thoughts are. If you think it should be here, that works for me too
There was a problem hiding this comment.
If the user presses one of the two buttons and then changes their mind, it seems that we will record their response multiple times. Should we do something to account for this?
There was a problem hiding this comment.
nit: It seems like we use the term good review / bad review and positive / negative. Can we centralize on 1 naming so its less confusing
There was a problem hiding this comment.
I'm wondering if we should just do feedback.name.lowercase() here
There was a problem hiding this comment.
I tried using talkback with the buttons. Thinking aloud, would it be more clear to make the content description have some sort of verb so its more like a call to action. I think something like Rate good summary would be good? Right now, users swipe from AI can make mistakes to Good summary, button - maybe this also depends on the placement, FWIW, which you were also skeptical about.
After commenting this, I also tested the buttons google search gemini and they say Good response, button, Bad response, button - so maybe it's more about the positioning then and not the content description
There was a problem hiding this comment.
It's a bit weird because if the user gives a rating, the content description becomes Bad summary, Button, disabled and Good summary, Button, disabled. I would also expect for the fact that a response was already selected to be announced somehow
nicholaspoon03
left a comment
nicholaspoon03
left a comment
There was a problem hiding this comment.
Hey Jeff,
Good work! Just a few things that I wanted to ask about and I don't know how data collection processes work on github - so I asked in slack to see how to do that
|
Stumbled upon this patch by accident. Patches with strings should not go through this workflow for now? |
4 participants
