Bug 2040618: Fix touch slop shenanigans.#291
Closed
pollym wants to merge 1 commit into
Closed
Conversation
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (:
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
|
No new issues detected. This pull request is 🆗 |
mcarare
approved these changes
Jun 15, 2026
|
Pull request closed by commit 7441856 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Jun 15, 2026
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (: Pull request: #291
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2026
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (: Pull request: mozilla-firefox/firefox#291 UltraBlame original commit: 37e8ddfc7c9d8a0e9480757c1469f05ea51da2a0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2026
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (: Pull request: mozilla-firefox/firefox#291 UltraBlame original commit: 37e8ddfc7c9d8a0e9480757c1469f05ea51da2a0
lando-worker Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (: Pull request: #291 Differential Revision: https://phabricator.services.mozilla.com/D308221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out touch slop isn't the right thing to use in this situation to differentiate between a tap and a swipe. It's the minimum distance to begin a drag, not a cutoff between a tap and swipe. So i've put the dp magic number back in! sorry andrey (: