Bug 2045749: Add game in new dialog to prevent talkback issues.#290
Bug 2045749: Add game in new dialog to prevent talkback issues.#290pollym wants to merge 1 commit into
Conversation
|
View this pull request in Lando to land it once approved. |
|
No new issues detected. This pull request is 🆗 |
pollym
force-pushed
the
fix-talkback-visibility-issue
branch
from
6901793 to
1952908
Compare
|
No new issues detected. This pull request is 🆗 |
segunfamisa
left a comment
segunfamisa
left a comment
There was a problem hiding this comment.
Code-wise, this looks good to me. I don't know why this fixed it though, or what other options could have helped here - I wonder if requesting focus for the game would bring the screen reader's focus there and it won't get stuck in the background?
Either way, this looks good to me, and thanks for handling the activity clean up!
| }, | ||
| ) | ||
|
|
||
| // On destroy, dismiss the window with the host so it can't leak if the activity goes away mid-game. |
that's fair. i would like to spend a bit of time looking at alternatives here for sure, there are probably nicer ways to handle it! |
|
Pull request closed by commit 6fb0376 |
…unfamisa I've also changed the feature API to pass in `Context` instead of the container `ViewGroup`. I don't love passing context as a parameter, but it is the thing we need to spawn a new dialog, so it makes more sense than passing in a `ViewGroup` and getting the `Context` from it. [there is a try here](https://treeherder.mozilla.org/jobs?repo=try&revision=eddb7ec074a0856f90d1a1c2fa4ca10c4a6db99d) Pull request: #290
…unfamisa I've also changed the feature API to pass in `Context` instead of the container `ViewGroup`. I don't love passing context as a parameter, but it is the thing we need to spawn a new dialog, so it makes more sense than passing in a `ViewGroup` and getting the `Context` from it. [there is a try here](https://treeherder.mozilla.org/jobs?repo=try&revision=eddb7ec074a0856f90d1a1c2fa4ca10c4a6db99d) Pull request: mozilla-firefox/firefox#290 UltraBlame original commit: 903f31d691887c84e64461976043131d46827e82
…unfamisa I've also changed the feature API to pass in `Context` instead of the container `ViewGroup`. I don't love passing context as a parameter, but it is the thing we need to spawn a new dialog, so it makes more sense than passing in a `ViewGroup` and getting the `Context` from it. [there is a try here](https://treeherder.mozilla.org/jobs?repo=try&revision=eddb7ec074a0856f90d1a1c2fa4ca10c4a6db99d) Pull request: mozilla-firefox/firefox#290 UltraBlame original commit: 903f31d691887c84e64461976043131d46827e82
2 participants
I've also changed the feature API to pass in
Contextinstead of the containerViewGroup.I don't love passing context as a parameter, but it is the thing we need to spawn a new dialog, so it makes more sense than passing in a
ViewGroupand getting theContextfrom it.there is a try here