Bug 2044193 - Exposed exceptions from LLM provider chooser#287
Closed
fmasalha wants to merge 1 commit into
Closed
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
fmasalha
commented
Jun 9, 2026
| @@ -7,7 +7,6 @@ package org.mozilla.fenix.components.llm.ext | |||
| import mozilla.components.lib.llm.mlpa.MlpaTokenProvider | |||
| import mozilla.components.lib.llm.mlpa.service.AuthorizationToken | |||
|
|
|||
| internal class AllTokenProvidersFailed : IllegalStateException("All token providers failed to retrieve a token.") | |||
Contributor
Author
There was a problem hiding this comment.
After speaking with Jeff, getting an integrity failure tells us all providers failed, and removing this just removes an extra wrap of the expression that we didnt need and now results to the actual handshake/verification failure code.
|
No new issues detected. This pull request is 🆗 |
boek
approved these changes
Jun 11, 2026
Contributor
Author
|
No new issues detected. This pull request is 🆗 |
|
Pull request closed by commit c4a78b6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.