Skip to content

Sprint 0 Day 0 quick wins: LICENSE, trust links, latent-bug fixes, dep cleanup, CI#1

Closed
mostafazh wants to merge 7 commits into
mainfrom
claude/day-0-quick-wins-pr-ydk6wq
Closed

Sprint 0 Day 0 quick wins: LICENSE, trust links, latent-bug fixes, dep cleanup, CI#1
mostafazh wants to merge 7 commits into
mainfrom
claude/day-0-quick-wins-pr-ydk6wq

Conversation

@mostafazh

Copy link
Copy Markdown
Owner

What & why

The project reads as a "stalled / abandoned personal project" even though the tool works. Per the Sprint 0 plan in the project-lead briefing, the highest-leverage first move is a small batch of no-questions-asked hygiene fixes that flip the trust signal and remove production-latent bugs — no leadership decisions, no media recordings, no merging of stale upstream PRs required.

Changes

  • Add MIT LICENSE — the README already claimed MIT but no file existed, so the repo defaulted to "all rights reserved" (blocks institutional/corporate adoption). (P1)
  • Fix README clone URL & directorypalestine-pfp-makerprofile-pic-maker; the old name 404s on a contributor's very first step. (P2)
  • Fix in-app bug-report link — same wrong repo name in page.tsx. (P3)
  • Replace personal-X feedback link (x.com/sohafidz) with the GitHub issues tracker — routes support to a TFP-owned, shared, archived inbox. Closes Link to github on page for bug reports TechForPalestine/profile-pic-maker#14. (P4)
  • Fix unsuportedBrowser typo (3 occurrences) → unsupportedBrowser. (P7)
  • Fix wrong useEffect deps → [] on the browser-detection and gaza-status fetch effects (latent re-fetch hazard). (P8)
  • Remove squatter / unused dependencies: child_process (npm squatter, not the Node built-in), sharp, browser-image-compression — zero imports anywhere in src/. Kept html2canvas since it's earmarked for the pending Linux-download fix (PR Fix download button not working on Linux browsers TechForPalestine/profile-pic-maker#102). (P14)
  • Add a minimal CI workflow (lint, type-check, build) on PRs and pushes to main — a fresh, version-current workflow rather than the 14-month-stale community PR. (P13)

Verification

Ran locally, all green:

npm run lint        # clean
npx tsc --noEmit    # no errors
npm run build       # compiled successfully

Also confirmed via git grep: no remaining unsuportedBrowser, palestine-pfp-maker, sohafidz, or removed-dependency references.

Deliberately deferred (need a decision / external action)

https://claude.ai/code/session_01Y7YCJxYMZmuTJtZwuuZNwM


Generated by Claude Code

claude added 7 commits June 9, 2026 00:48
README claimed an MIT license but no LICENSE file existed, which defaults
the repo to 'all rights reserved' and blocks institutional adoption. Uses
TechForPalestine's official MIT license text.
The clone command and project directory referenced the old repo name
'palestine-pfp-maker', which 404s. Update both to 'profile-pic-maker'.
Drop three dependencies with zero imports anywhere in src/:
- child_process: an npm squatter, not the Node built-in
- sharp: server-only, unreferenced
- browser-image-compression: unreferenced

Keeps html2canvas, which is earmarked for the pending Linux download fix.
Runs on pull requests and pushes to main. A fresh, version-current
workflow rather than the stale community CI PR.
Both effects run once on mount, but their dependency arrays referenced the
state they set (unsuportedBrowser, gazaStatusSummary). Use [] to avoid a
latent re-run/re-fetch hazard.
Rename the misspelled state variable to unsupportedBrowser (the setter was
already correctly spelled).
… link

The landing page had two separate footer links: a 'feedback' link pointing
to a personal X account (x.com/sohafidz) and a 'report bugs' link pointing
to an outdated repo URL. Merge them into one link to the GitHub issues
tracker, so feedback, questions, and bug reports all route to a TFP-owned,
shared, archived inbox.

Closes TechForPalestine#14.
@mostafazh mostafazh force-pushed the claude/day-0-quick-wins-pr-ydk6wq branch from b49dc52 to 3080f77 Compare June 9, 2026 00:51
mostafazh pushed a commit that referenced this pull request Jun 12, 2026
Adds a 'Shipped' section covering: PR #1 (hygiene, LICENSE, trust
links, latent-bug fixes, dep cleanup, CI gate), PR #2 (integration +
e2e + live-smoke tests for the core flow), and the self-hosted how-to
video branch. Strikes through the completed dep-hygiene item and
updates sequencing for the remaining four wins.

https://claude.ai/code/session_014uS7FQWjFgjS3Qx5Mdjwhu
mostafazh pushed a commit that referenced this pull request Jun 12, 2026
Verified claude/video-how-to-guide-m7r4cw: merges cleanly with PR #1
and the MP4 is a valid H.264 faststart file, but next build fails on a
prettier/prettier error at src/app/page.tsx:131. Doc now notes the
one-line fix needed before a PR is opened.

https://claude.ai/code/session_014uS7FQWjFgjS3Qx5Mdjwhu
@mostafazh mostafazh closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to github on page for bug reports

2 participants