Skip to content

Propagate error - #68

Open
hmalphettes wants to merge 2 commits into
morris:masterfrom
sutoiku:propagate-src-error
Open

Propagate error#68
hmalphettes wants to merge 2 commits into
morris:masterfrom
sutoiku:propagate-src-error

Conversation

@hmalphettes

Copy link
Copy Markdown
Contributor

Testing with an ftp URL that does not hit the right port, I get an UncaughtException.

This patch will propagate the error so that it can be handled with an error listener on the stream returned by vinylFtp.src

Thanks again for your attention!

@morris

morris commented Sep 30, 2016

Copy link
Copy Markdown
Owner

This looks like a hack, the error should be propagated already. Maybe it's an issue with the parallel stream? Might be better to fix that instead.

@morris morris added the bug label Sep 30, 2016
@hmalphettes

Copy link
Copy Markdown
Contributor Author

@morris as far as I understand and as I have experienced it, it is expected that when one uses pipe one is in charge of setting up the error propagation.

Here is an old thread from 2012:
https://groups.google.com/forum/#!topic/nodejs/lJYT9hZxFu0
or a more concise summary: http://stackoverflow.com/a/22389498/1273401

In my code I never use pipe.
I rely on https://github.com/mafintosh/pump and https://github.com/alessioalex/bubble-stream-error to propagate the errors and destroy each step of the pipeline.

@hmalphettes

Copy link
Copy Markdown
Contributor Author

@morris I apologize if you are already on the top of all this.
I have not used parallel-transform much really.

@morris

morris commented Oct 6, 2016

Copy link
Copy Markdown
Owner

No problem at all! I'm glad you found an issue and contributed a solution. I'll dig into this many thanks 👍

@arabm

arabm commented May 6, 2017

Copy link
Copy Markdown

@morris Did you had time to dig into it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants