Fix CI workflow and lint compatibility#1
Merged
Conversation
Repair the CockroachDB startup step in CI, switch golangci-lint to the v2 CLI path that matches the repo config, and clean up the newly surfaced lint violations so pull request checks can run cleanly again. Co-authored-by: Cursor <cursoragent@cursor.com>
Pin GitHub Actions to a patched Go toolchain, simplify the Cockroach startup commands so integration jobs start reliably, and drop the old license-options file and README reference now that Apache-2.0 is the settled license. Co-authored-by: Cursor <cursoragent@cursor.com>
The current CockroachDB build rejects the 0.25GiB in-memory store size on GitHub-hosted runners because the minimum allowed size is higher. Raise the CI and release workflow store size so the integration job can start the database successfully. Co-authored-by: Cursor <cursoragent@cursor.com>
The integration job reuses one Cockroach database across packages, so running `go test ./...` in parallel lets multiple packages race the migration step. Run integration packages with `-p 1` in CI and release workflows so the shared test database stays stable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CIintegration workflowgolangci-lintv2 CLI install path so it matches the repo config and Go toolchain targetTest plan
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest && \"$(go env GOPATH)/bin/golangci-lint\" rungo test ./...Made with Cursor