fix: post-#21 merge hygiene (schema duplicate + blocks_from_analysis)#26
Merged
Merged
Conversation
Drop the duplicate analysis-plan allOf column-required rule left by the late #21 merge, and teach blocks_from_analysis to render histogram, stacked_bar, and scatter_chart so suggest→render stays in lockstep. Co-authored-by: moonlight-lupin <moonlight-lupin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two leftovers from landing #21 after the viz/filter work:
analysis-plan.schema.json— remove the duplicateallOfrule that requiredcolumnfornumeric_summary/outliers_iqr/currency_mixa second time. The Expose full data-analyse engine ops on the plan surface #21 rule (which also coversdistribution) remains;filter_rowsand the other 12 ops are unchanged (still 19 ops on the plan surface).blocks_from_analysis— renderhistogram,stacked_bar, andscatter_chart.suggest_blocks_from_analysisalready proposed the first two fordistribution/pivot, but the convenience helper raisedunsupported block type. Agent runtime was unaffected (suggest→_viz_block).Version bump
0.8.1→0.8.2. Existing suggest-block tests now also assert the HTML render path.Verification
python3 tests/test_engine.py— 73/73python3 tests/test_agent_runtime.py— 21/21python3 tests/test_agent_schemas.py— 13/13