Blueprint insert properties and events in order when undoing#76
Open
Stuk wants to merge 2 commits into
Open
Conversation
Contributor
|
Looks like it would work, though “addValueToSetAt” really ought to be “set.splice” and implemented in Collections. Please file an issue against Collections to implement this, and if you merge this, make an issue and a note in the code to fix it when the foundation is laid. |
Contributor
Author
|
Issue filed montagejs/collections#37 I'll look at implementing it properly in a free moment |
Contributor
|
This relies on montagejs/montage#1393. Looking into that one right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing that really needs some review is
core/add-value-to-set-atas this isn't supported on the Set. @kriskowal do you have any thoughts?