[FIL-678] Use esprima to validate javascript code in realtime#420
Open
pchaussalet wants to merge 2 commits into
Open
[FIL-678] Use esprima to validate javascript code in realtime#420pchaussalet wants to merge 2 commits into
pchaussalet wants to merge 2 commits into
Conversation
|
Can one of the admins verify this patch? (Reply "ok to test") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every javascript code change, a code parsing is ran using esprima. If a syntax error is found (ie. esprima throws an exception), a mark is added to the corresponding line and the tokens before and after the error location are underlined.
The syntax parsing is done in a specific service, so it should be easy to plug another parser, like one that could parse and validate css or html code.