Skip to content

Delete shortcut#406

Open
3on wants to merge 3 commits into
montagestudio:masterfrom
3on:delete-shortcut
Open

Delete shortcut#406
3on wants to merge 3 commits into
montagestudio:masterfrom
3on:delete-shortcut

Conversation

@3on

@3on 3on commented Jun 12, 2014

Copy link
Copy Markdown
Contributor

Depends on a Montage bug: montagejs/montage#1481

@mczepiel

Copy link
Copy Markdown
Contributor

Can't delete when editing in a text field (default doesn't work as expected)

@mczepiel

Copy link
Copy Markdown
Contributor

Oh unless I didn't have the change form montage applied…

@3on

3on commented Jun 16, 2014

Copy link
Copy Markdown
Contributor Author

Yeah Montage needs to be patched

@ducarroz

Copy link
Copy Markdown
Contributor

I am having a conceptual issue with the whole thing. The App has now a edit/delete menu item with a short cut. However that menu item is disabled when the focus is on a textfield!

Even if we fix the issue related to preventDefault (montagejs/montage#1481) for which I am not fully convinced yet this is a bug. The menu item should not be disabled in that case and the user should be able to delete text inside a textfield by using the menu item. In that case, we would not need to address the key-composer issue at all as the shortcut is properly fired when the user press Delete (the menu blink right now).

@hthetiot hthetiot added this to the M17 milestone Jun 22, 2017
@hthetiot hthetiot requested a review from cdebost June 22, 2017 22:46
@hthetiot hthetiot removed this from the M17 milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants