Make initial loader opaque to hide app loading#390
Open
mczepiel wants to merge 2 commits into
Open
Conversation
I also brought the loader widget higher up along the z axis so it's visible if necessary,but it doesn't look quite right as it doesn't have the same dimensions as the loader that follows it (very quickly) due to the text and some extra padding. I don't want to lose the bootstrapping loader but wouldn't mind it being different enough that the jump to the actual longer loader is less jarring.
Contributor
Author
|
@simurai, please look this over; I don't think it looks great but the mechanics are in place.
|
Contributor
|
We could make both loaders have the same position, but there would still be a flash when they switch, right? Plus the colors wouldn't match. Ok, sure. Let's change the first "bootstrap" loader to something else.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I also brought the loader widget higher up along the z axis so it's
visible if necessary,but it doesn't look quite right as it doesn't have
the same dimensions as the loader that follows it (very quickly) due
to the text and some extra padding.
I don't want to lose the bootstrapping loader but wouldn't mind it
being different enough that the jump to the actual longer loader is
less jarring.