Save glTF bundles after having converted it, but save it separately#335
Save glTF bundles after having converted it, but save it separately#335thibaultzanini wants to merge 1 commit into
Conversation
In order to improve user experience.
|
Thanks @thibaultzanini , @mczepiel you should see a huge difference with this. |
|
This will need some work on top of the commit batches from @ducarroz And at this point you shouldn't need to do so much manually, it will hopefully be a matter of opening the batch, adding the files that gltf has created, and then closing the batch. "Saving" which used to include pushing, no longer includes pushing. The push is scheduled. But we do need to restore some part of this now; without expliclty saving we don't seem to commit the glTF bundle results as I'd expect. Though I guess I'm not sure when I'd expect that seeing as it;s usually part of some other editing operation that does need to be saved. Can I see a sequence of when you expect conversion to happen and when we expect it to save to disk, be included in a commit, etc? |
|
Just dragging & dropping a collada model file from the asset library to the path property of a scene object will convert and save the glTF bundle. So, I assume that should work like when we create/delete a folder, right ? How that works exactly now (the push thing) ? |
|
Most compact example I see is here https://github.com/declarativ/filament/blob/master/core/project-document.js#L293, opening the batch, "staging" files (in this case, for deletion), and then closing the batch when completed. I hope you can just open as part of the conversion, stage the glTF bundle itself, an then close the commit. That sound right @ducarroz? |
In order to improve the user experience.
Need this PR to be merged first:
montagestudio/firefly#181