Skip to content

Save glTF bundles after having converted it, but save it separately#335

Open
thibaultzanini wants to merge 1 commit into
montagestudio:masterfrom
thibaultzanini:save-gltf-separately
Open

Save glTF bundles after having converted it, but save it separately#335
thibaultzanini wants to merge 1 commit into
montagestudio:masterfrom
thibaultzanini:save-gltf-separately

Conversation

@thibaultzanini

Copy link
Copy Markdown
Contributor

In order to improve the user experience.

Need this PR to be merged first:
montagestudio/firefly#181

@fabrobinet

Copy link
Copy Markdown
Contributor

Thanks @thibaultzanini , @mczepiel you should see a huge difference with this.

@thibaultzanini thibaultzanini deleted the save-gltf-separately branch May 9, 2014 22:51
@thibaultzanini thibaultzanini restored the save-gltf-separately branch May 9, 2014 22:52
@thibaultzanini thibaultzanini reopened this May 9, 2014
@mczepiel

Copy link
Copy Markdown
Contributor

This will need some work on top of the commit batches from @ducarroz

And at this point you shouldn't need to do so much manually, it will hopefully be a matter of opening the batch, adding the files that gltf has created, and then closing the batch.

"Saving" which used to include pushing, no longer includes pushing. The push is scheduled.

But we do need to restore some part of this now; without expliclty saving we don't seem to commit the glTF bundle results as I'd expect. Though I guess I'm not sure when I'd expect that seeing as it;s usually part of some other editing operation that does need to be saved.

Can I see a sequence of when you expect conversion to happen and when we expect it to save to disk, be included in a commit, etc?

@thibaultzanini

Copy link
Copy Markdown
Contributor Author

Just dragging & dropping a collada model file from the asset library to the path property of a scene object will convert and save the glTF bundle. So, I assume that should work like when we create/delete a folder, right ?

How that works exactly now (the push thing) ?

@mczepiel

Copy link
Copy Markdown
Contributor

Most compact example I see is here https://github.com/declarativ/filament/blob/master/core/project-document.js#L293, opening the batch, "staging" files (in this case, for deletion), and then closing the batch when completed.

I hope you can just open as part of the conversion, stage the glTF bundle itself, an then close the commit. That sound right @ducarroz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants